[Form Provider Refactor] AddDebitCardPage #29983

kowczarz · 2023-10-19T14:27:51Z

Details

Fixed Issues

$ #28876
$ #30005

Tests

Log in
Press on your profile picture to open Settings > Wallet
If wallet is empty press Add payment method
Fill form with correct data
Save the card data

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.native_H.265.mp4

Android: mWeb Chrome

android.web_H.265.mp4

iOS: Native

ios.native_H.265.mp4

iOS: mWeb Safari

ios.web_H.265.mp4

MacOS: Chrome / Safari

web_H.265.mp4

MacOS: Desktop

desktop_H.265.mp4

melvin-bot · 2023-10-19T14:27:56Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-10-19T15:48:06Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kowczarz · 2023-10-20T09:30:02Z

src/components/AddressSearch/index.js

+function AddressSearch({
+    canUseCurrentLocation,
+    containerStyles,
+    defaultValue,
+    errorText,
+    hint,
+    innerRef,
+    inputID,
+    isLimitedToUSA,
+    label,
+    maxInputLength,
+    network,
+    onBlur,
+    onInputChange,
+    onPress,
+    predefinedPlaces,
+    preferredLocale,
+    renamedInputKeys,
+    resultTypes,
+    shouldSaveDraft,
+    translate,
+    value,
+}) {


I had to spread props to avoid disabling eslint exhaustive-deps rule in line 372.

kowczarz · 2023-10-20T09:30:22Z

@luacmartins can you take a look on this?

parasharrajat · 2023-10-20T10:00:26Z

Reviewing...

src/components/CheckboxWithLabel.js

src/components/AddressSearch/index.js

luacmartins · 2023-10-20T16:37:19Z

src/components/AddressSearch/index.js

@@ -342,6 +364,26 @@ function AddressSearch(props) {
        };
    }, []);

+    const listEmptyComponent = useCallback(


I think we can use useMemo here since we just want to store the value

I think the function is best suited for a child to be used as a functional component. Otherwise, the react lifecycle will not work properly and the prop used inside network.isOffline will not work as expected.

@luacmartins I think I think it's safer to use callback and the value of the prop needs to be a function.

src/components/AddressSearch/index.js

parasharrajat · 2023-10-20T18:27:54Z

BUG: Web: I don't see error warnings for the following fields.

Attached image is taken on staging.

parasharrajat · 2023-10-23T12:55:37Z

Bump @kowczarz

luacmartins · 2023-10-23T18:08:36Z

@kowczarz lint is failing!

parasharrajat · 2023-10-30T09:17:08Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-10-30.at.2.45.32.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-10-25.at.11.02.38.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-10-30.at.2.37.05.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-10-30.at.2.38.17.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-10-25.at.11.00.52.PM.mov

🔲 Android / native

Screen.Recording.2023-10-25.at.11.04.48.PM.mov

parasharrajat · 2023-10-30T09:19:28Z

Waiting on conflicts to be resolved before approving. cc: @kowczarz

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2023-10-30T09:20:37Z

I will recheck when conflcits are resolved.

cdOut · 2023-10-30T10:21:58Z

@parasharrajat conflicts resolved, please recheck the PR

src/components/CheckboxWithLabel.js

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

cdOut · 2023-10-30T12:06:13Z

@parasharrajat please recheck this PR

src/components/Form/InputWrapper.js

parasharrajat

LGTM.

OSBotify · 2023-10-30T16:08:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-31T22:00:52Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-01T08:52:51Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:16:12Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:41:02Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-06T22:11:05Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kowczarz added 6 commits October 19, 2023 10:46

WIP

b4d942f

Fix checkbox proptypes

a348d1b

Fix address search prop type issue

38d9184

Add checkbox default value

00e12fc

Prettier

b05c8ba

Spread props

c290dbb

Lint fix

64dbcd4

kowczarz marked this pull request as ready for review October 19, 2023 15:48

kowczarz requested a review from a team as a code owner October 19, 2023 15:48

melvin-bot bot requested review from parasharrajat and removed request for a team October 19, 2023 15:48

kowczarz commented Oct 20, 2023

View reviewed changes

kowczarz mentioned this pull request Oct 20, 2023

[$500] [Form Provider Refactor] AddressPage #28872

Closed

kowczarz mentioned this pull request Oct 20, 2023

[$125] [Form Provider Refactor] WaypointEditor #30008

Closed

blazejkustra approved these changes Oct 20, 2023

View reviewed changes

parasharrajat reviewed Oct 20, 2023

View reviewed changes

src/components/CheckboxWithLabel.js Outdated Show resolved Hide resolved

Fix propType

196689d

kowczarz requested a review from parasharrajat October 20, 2023 14:36

luacmartins self-requested a review October 20, 2023 15:26

luacmartins reviewed Oct 20, 2023

View reviewed changes

Code review changes

b418a4c

kowczarz added 2 commits October 24, 2023 12:11

Fix not displaying all errors

280e8f6

Fix prettier

677c2a5

parasharrajat approved these changes Oct 30, 2023

View reviewed changes

melvin-bot bot requested a review from luacmartins October 30, 2023 09:20

cdOut added 2 commits October 30, 2023 11:05

merge main into form-migration/add-debit-card-page

58f09ab

fix lint errors and include new import method

6a4f127

cdOut dismissed luacmartins’s stale review via 6a4f127 October 30, 2023 10:16

parasharrajat reviewed Oct 30, 2023

View reviewed changes

src/components/CheckboxWithLabel.js Show resolved Hide resolved

cdOut and others added 2 commits October 30, 2023 12:52

Update src/components/CheckboxWithLabel.js

0f6688b

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

revert import to fix prettier and lint

b35ebf5

parasharrajat reviewed Oct 30, 2023

View reviewed changes

src/components/Form/InputWrapper.js Show resolved Hide resolved

parasharrajat reviewed Oct 30, 2023

View reviewed changes

src/components/Form/InputWrapper.js Outdated Show resolved Hide resolved

remove unused code

890dd54

parasharrajat approved these changes Oct 30, 2023

View reviewed changes

luacmartins approved these changes Oct 30, 2023

View reviewed changes

luacmartins merged commit 052fd0b into Expensify:main Oct 30, 2023
15 checks passed

OSBotify mentioned this pull request Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

lanitochka17 mentioned this pull request Nov 1, 2023

[HOLD for payment 2023-12-06] [HOLD for payment 2023-11-28] Wallet - After tapping on the debit card number field, an error message appears #30703

Closed

6 tasks

This was referenced Nov 2, 2023

[HOLD for payment 2023-12-06] [HOLD for payment 2023-11-09] [$500] [Form Provider Refactor] AddDebitCardPage #28876

Closed

[HOLD for payment 2023-12-06] [HOLD for payment 2023-11-09] [Form Provider Refactor] WorkspaceNewRoomPage #30005

Closed

OSBotify mentioned this pull request Nov 2, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Form Provider Refactor] AddDebitCardPage #29983

[Form Provider Refactor] AddDebitCardPage #29983

kowczarz commented Oct 19, 2023 •

edited

Loading

melvin-bot bot commented Oct 19, 2023

melvin-bot bot commented Oct 19, 2023

kowczarz Oct 20, 2023

kowczarz commented Oct 20, 2023

parasharrajat commented Oct 20, 2023

luacmartins Oct 20, 2023

parasharrajat Oct 20, 2023

kowczarz Oct 24, 2023 •

edited

Loading

parasharrajat commented Oct 20, 2023 •

edited

Loading

parasharrajat commented Oct 23, 2023

luacmartins commented Oct 23, 2023

parasharrajat commented Oct 30, 2023

parasharrajat commented Oct 30, 2023

parasharrajat left a comment •

edited

Loading

parasharrajat commented Oct 30, 2023

cdOut commented Oct 30, 2023

cdOut commented Oct 30, 2023

parasharrajat left a comment

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

OSBotify commented Nov 1, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

[Form Provider Refactor] AddDebitCardPage #29983

[Form Provider Refactor] AddDebitCardPage #29983

Conversation

kowczarz commented Oct 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 19, 2023

melvin-bot bot commented Oct 19, 2023

kowczarz Oct 20, 2023

Choose a reason for hiding this comment

kowczarz commented Oct 20, 2023

parasharrajat commented Oct 20, 2023

luacmartins Oct 20, 2023

Choose a reason for hiding this comment

parasharrajat Oct 20, 2023

Choose a reason for hiding this comment

kowczarz Oct 24, 2023 • edited Loading

Choose a reason for hiding this comment

parasharrajat commented Oct 20, 2023 • edited Loading

parasharrajat commented Oct 23, 2023

luacmartins commented Oct 23, 2023

parasharrajat commented Oct 30, 2023

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat commented Oct 30, 2023

parasharrajat left a comment • edited Loading

Choose a reason for hiding this comment

Reviewer Checklist

parasharrajat commented Oct 30, 2023

cdOut commented Oct 30, 2023

cdOut commented Oct 30, 2023

parasharrajat left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

OSBotify commented Nov 1, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

kowczarz commented Oct 19, 2023 •

edited

Loading

kowczarz Oct 24, 2023 •

edited

Loading

parasharrajat commented Oct 20, 2023 •

edited

Loading

parasharrajat left a comment •

edited

Loading